j1wonpark commented on code in PR #4244:
URL: https://github.com/apache/amoro/pull/4244#discussion_r3417909979
##########
pom.xml:
##########
@@ -1491,6 +1511,8 @@
<version>${maven-surefire-plugin.version}</version>
<configuration>
<failIfNoSpecifiedTests>false</failIfNoSpecifiedTests>
+ <argLine>${amoro.surefire.baseArgLine}</argLine>
+
<excludedGroups>${surefire.excludedGroups.jdk}</excludedGroups>
Review Comment:
nit: `surefire.excludedGroups.jdk` isn't defined anywhere (`help:evaluate` →
null, stays literal in the effective POM), and there are no `@Category`/`@Tag`
groups to exclude. Unused placeholder — maybe drop it or give it an empty
default. (Same in `amoro-mixed-flink-common/pom.xml`.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
