xxubai commented on code in PR #4244:
URL: https://github.com/apache/amoro/pull/4244#discussion_r3419451889
##########
amoro-format-mixed/amoro-mixed-flink/amoro-mixed-flink-common/src/main/java/org/apache/amoro/flink/interceptor/KerberosInvocationHandler.java:
##########
@@ -56,7 +56,6 @@ public Object invoke(Object proxy, Method method, Object[]
args) throws Throwabl
authenticatedFileIO.doAs(
() -> {
try {
- method.setAccessible(true);
Review Comment:
`KerberosInvocationHandler` currently proxies methods exposed through the
proxied object's **interfaces**.
In practice, the invocation path goes through public interfaces such as
`OneInputStreamOperator` and `SourceFunction`. As a result, these method
invocations do not require `method.setAccessible(true)`.
Keeping `method.setAccessible(true)` would introduce unnecessary
deep-reflection behavior, which is exactly what this JDK17 compatibility change
is trying to avoid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
