xxubai commented on code in PR #4339:
URL: https://github.com/apache/amoro/pull/4339#discussion_r3878212339
##########
amoro-ams/src/main/java/org/apache/amoro/server/AmoroServiceContainer.java:
##########
@@ -316,11 +348,6 @@ public void disposeOptimizingService() {
LOG.info("Stopping optimizing server[serving:{}] ...",
optimizingServiceServer.isServing());
optimizingServiceServer.stop();
}
- if (amsAssignService != null) {
Review Comment:
`dispose()` still calls `disposeOptimizingService()` directly from the
shutdown hook. Will it cause the `ams-assign-scheduler` running while the other
services are being disposed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
