zhoujinsong commented on code in PR #4339:
URL: https://github.com/apache/amoro/pull/4339#discussion_r3878721391
##########
amoro-ams/src/main/java/org/apache/amoro/server/AmoroServiceContainer.java:
##########
@@ -316,11 +348,6 @@ public void disposeOptimizingService() {
LOG.info("Stopping optimizing server[serving:{}] ...",
optimizingServiceServer.isServing());
optimizingServiceServer.stop();
}
- if (amsAssignService != null) {
Review Comment:
Yes, we may stop the leader service first, if necessary, when disposing.
I have made some change, PTAL.
##########
amoro-ams/src/main/java/org/apache/amoro/server/AmoroServiceContainer.java:
##########
@@ -316,11 +348,6 @@ public void disposeOptimizingService() {
LOG.info("Stopping optimizing server[serving:{}] ...",
optimizingServiceServer.isServing());
optimizingServiceServer.stop();
}
- if (amsAssignService != null) {
Review Comment:
Yes, we may stop the leader service first, if necessary, when disposing.
I have made some changes, PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
