Akeron-Zhu opened a new pull request, #4358:
URL: https://github.com/apache/amoro/pull/4358
## Why are the changes needed?
Close #4357.
When configuring table-level properties on a catalog, the property key must
be
prefixed with `table.`. The prefix is automatically stripped when the
property
is applied to tables. However, this requirement is not documented anywhere in
the user-facing documentation, which can easily lead to misconfiguration.
For example, to set the default optimizer group for all tables under a
catalog,
users must configure `table.self-optimizing.group` instead of
`self-optimizing.group`. Properties without the `table.` prefix will not be
recognized as table-level defaults and will be silently ignored.
This behavior is defined in code:
- `CatalogMetaProperties.TABLE_PROPERTIES_PREFIX = "table."`
(`CatalogMetaProperties.java:91`)
- `catalogUtil.mergeCatalogPropertiesToTable()` extracts only keys starting
with
`table.` and strips the prefix (`CatalogUtil.java:107-120`)
## Brief change log
- Added a hint and examples to the "Configure table properties" section in
`docs/admin-guides/managing-catalogs.md`:
- Added a `{{< hint info >}}` block clarifying that keys **must** be
prefixed
with `table.` and that the prefix is automatically stripped.
- Added an example table mapping catalog property keys to their effective
table property keys, including:
- `table.self-optimizing.enabled` → `self-optimizing.enabled`
- `table.self-optimizing.group` → `self-optimizing.group`
- `table.table-expire.enabled` → `table-expire.enabled`
- `table.clean-orphan-file.enabled` → `clean-orphan-file.enabled`
- `table.log-store.enabled` → `log-store.enabled`
- Linked to the [Table configurations](../configurations/) page for a
complete
list of available table properties.
## How was this patch tested?
- [ ] Add some test cases that check the changes thoroughly including
negative and positive cases if possible
- [x] Add screenshots for manual tests if appropriate
- Rendered the doc page locally with Hugo to verify the hint block and
table display correctly.
- [x] Run test locally before making a pull request
- Only documentation files changed; no code or test impact.
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
