czy006 commented on PR #4358: URL: https://github.com/apache/amoro/pull/4358#issuecomment-5559359680
Hi @Akeron-Zhu , thanks for the doc fix — I verified the mechanism against CatalogUtil.mergeCatalogPropertiesToTable() and all the example keys check out. LGTM with one minor nit: The PR description mentions linking to the "Table configurations" page, but no such link was actually added in the diff. It would be helpful to add one so readers can find the full list of available table properties. One thing to note: the correct relative path from docs/admin-guides/managing-catalogs.md is ../user-guides/configurations.md — a link to ../configurations/ (as written in the description) would be broken, since there is no docs/configurations/ directory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
