sy-records commented on code in PR #1188:
URL: https://github.com/apache/incubator-answer/pull/1188#discussion_r1862970177
##########
ui/src/services/common.ts:
##########
@@ -189,8 +190,10 @@ export const setNotice = (params: Type.SetNoticeReq) => {
};
export const saveQuestion = (params: Type.QuestionParams) => {
+ params.tags = params.tags || [];
+ params.content = params.content || '';
return request.post('/answer/api/v1/question', params);
-};
+}
Review Comment:
Need add `;`
##########
ui/src/services/common.ts:
##########
@@ -117,6 +117,7 @@ export const modifyQuestion = (
return request.put(`/answer/api/v1/question`, params);
};
+
Review Comment:
Useless empty line
##########
cmd/wire_gen.go:
##########
@@ -1,28 +1,8 @@
-//go:build !wireinject
Review Comment:
You need to revert this change.
##########
data/conf/config.yaml:
##########
@@ -0,0 +1,21 @@
+debug: false
Review Comment:
No need to submit `data`
##########
docs/docs.go:
##########
@@ -1,22 +1,3 @@
-/*
Review Comment:
The ASF header needs to be preserved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
