sosyz commented on PR #1188:
URL:
https://github.com/apache/incubator-answer/pull/1188#issuecomment-2513683304
Thank you for your contribution and addressing these two issues! 🎉
I really appreciate your effort and would like to suggest a few minor
improvements to help make this PR even better:
1. Code Organization:
- Could you please squash your commits into a single, clean commit?
- You can use `git squash` for this, followed by `git push -f` to update
your repository
- Pro tip: Consider backing up your code or trying this in a new branch
first if you're new to squashing
2. Commit Message:
- Let's enhance the commit message to better describe your changes
- You can refer to other commits in our repository for the format
- A good commit message helps other developers quickly understand the
changes
3. Repository Cleanup:
- The `data` directory contains runtime data files which shouldn't be
tracked in Git
- Please remove this directory from your commit
- You can do this while squashing your commits
4. ASF Headers:
- Please keep the original ASF headers unchanged
- No need to include ASF header modifications in your commit
If you need any help with these changes or have questions, please don't
hesitate to ask. I'm here to help! 😊
Thank you again for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
