DanielAuerX commented on code in PR #1335:
URL: https://github.com/apache/answer/pull/1335#discussion_r2091264274
##########
ui/src/pages/Users/Settings/Profile/index.tsx:
##########
@@ -241,10 +241,7 @@ const Index: React.FC = () => {
modifyUserInfo(params)
.then(() => {
- update({
- ...user,
- ...params,
- });
+ getLoggedUserInfo().then(update);
Review Comment:
+ checkout branch
+ remove the commit in question
+ upload a custom avatar
+ update the custom avatar with another avatar
+ check the logs and/or the uploads/avatar/ get requests
##########
internal/service/siteinfo/siteinfo_service.go:
##########
@@ -438,3 +442,43 @@ func (s *SiteInfoService) UpdatePrivilegesConfig(ctx
context.Context, req *schem
}
return
}
+
+func (s *SiteInfoService) CleanUpRemovedBrandingFiles(
+ ctx context.Context,
+ newBranding *schema.SiteBrandingReq,
+ currentBranding *schema.SiteBrandingResp,
+) error {
Review Comment:
returning all errors now, so that the log (in the controller) provides
information on the file(s) that caused an error
##########
ui/src/pages/Users/Settings/Profile/index.tsx:
##########
@@ -241,10 +241,7 @@ const Index: React.FC = () => {
modifyUserInfo(params)
.then(() => {
- update({
- ...user,
- ...params,
- });
+ getLoggedUserInfo().then(update);
Review Comment:
my response is still pending, idk why:
- checkout branch
- remove the commit in question
- upload a custom avatar
- update the custom avatar with another avatar
- check the logs and/or the uploads/avatar/ get requests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@answer.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
