shuashuai commented on code in PR #1335:
URL: https://github.com/apache/answer/pull/1335#discussion_r2097274956
##########
ui/src/pages/Users/Settings/Profile/index.tsx:
##########
@@ -241,10 +241,7 @@ const Index: React.FC = () => {
modifyUserInfo(params)
.then(() => {
- update({
- ...user,
- ...params,
- });
+ getLoggedUserInfo().then(update);
Review Comment:
> Just for clarification, this change is not supposed to eliminate browser
cache. Its supposed to be updating the user information, so an old avatar file
is not being requested after it has been removed from the user information.
This is not new behavior. However, previously requesting an old resource was
successful, because files were not being deleted.
Both ways of updating the user's information are the same and there is no
practical difference between them!
> Do you have a better solution? I can also just remove the commit, if you
think this is acceptable.
There is no better way at the moment, so let's keep the previous logic for
the time being.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@answer.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
