Github user tliron commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/199#discussion_r148621970
  
    --- Diff: aria/__init__.py ---
    @@ -17,14 +17,45 @@
     The ARIA root package provides entry points for extension and storage 
initialization.
     """
     
    +import os
     import sys
    +import types
     
     from pkgutil import iter_modules
     import pkg_resources
    -
     aria_package_name = 'apache-ariatosca'
     __version__ = pkg_resources.get_distribution(aria_package_name).version
     
    +
    +
    +
    +try:
    +    import ruamel                                           # noqa: F401
    +except ImportError:
    --- End diff --
    
    I recent commit removed Py2.6 support and allowed us to upgrade ruamel to 
its latest version. So, I suggest rebasing on master and testing again: perhaps 
this hack isn't needed anymore.
    
    Assuming this hack is still needed, we need to find a way to generalize it, 
since we import ruamel in many, many places in the code. Perhaps we should have 
an {{aria.utils.yaml}} package where we do all this work once. Everywhere else 
we use yaml would then have to be replaced to {{from aria.utils.yaml import 
yaml}}. A nice side benefit would be that it would be easy to replace ruamel 
with a different yaml parser is that is ever necessary.


---

Reply via email to