Github user tliron commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/199#discussion_r149136650
  
    --- Diff: aria/__init__.py ---
    @@ -17,14 +17,45 @@
     The ARIA root package provides entry points for extension and storage 
initialization.
     """
     
    +import os
     import sys
    +import types
     
     from pkgutil import iter_modules
     import pkg_resources
    -
     aria_package_name = 'apache-ariatosca'
     __version__ = pkg_resources.get_distribution(aria_package_name).version
     
    +
    +
    +
    +try:
    +    import ruamel                                           # noqa: F401
    +except ImportError:
    --- End diff --
    
    I just think `from aria.utils.yaml import yaml` will give us a clean 
separation in case we have a better fix in the future, so I do prefer that.
    
    Also, for this PR to merge we need to change *all* our uses of ruamel in 
the codebase to that import.


---

Reply via email to