Github user aviyoop commented on a diff in the pull request:
https://github.com/apache/incubator-ariatosca/pull/207#discussion_r151187582
--- Diff: aria/parser/loading/loader.py ---
@@ -32,3 +32,6 @@ def close(self):
def load(self):
raise NotImplementedError
+
+ def get_canonical_location(self):
# pylint: disable=no-self-use
--- End diff --
Seeing that this is the 'base' Loader class, I know that a lot of time we
just declare methods here that raise `NotImplementedError` or just `pass`.
Assuming that this is a way to 'declare' these methods to the child classes, I
understand its need. But combined with a method that returns `None`, where this
`Loader` class is not intended for direct use, is confusing.
---
