Github user aviyoop commented on a diff in the pull request:

    https://github.com/apache/incubator-ariatosca/pull/207#discussion_r151398089
  
    --- Diff: aria/parser/presentation/field_validators.py ---
    @@ -14,12 +14,29 @@
     # limitations under the License.
     
     
    +from ...utils.formatting import safe_repr
     from ..validation import Issue
     from .utils import (parse_types_dict_names, report_issue_for_unknown_type,
                         report_issue_for_parent_is_self, 
report_issue_for_unknown_parent_type,
                         report_issue_for_circular_type_hierarchy)
     
     
    +def not_negative_validator(field, presentation, context):
    --- End diff --
    
    Maybe you should use `__gt__()` and `<` instead. I've seen somewhere else 
that you replaced a custom equality method with an override of `__eq__()`.


---

Reply via email to