alien11689 commented on code in PR #5: URL: https://github.com/apache/aries-antora-site/pull/5#discussion_r3330461462
########## modules/ROOT/pages/modules/rsa.adoc: ########## @@ -1,76 +1,105 @@ = RSA (Remote Service Admin) -The Aries Remote Service Admin (RSA) project allows to transparently use OSGi services for remote communication. -OSGi services can be marked for export by adding a service property `service.exported.interfaces=*`. -Various other properties can be used to customize how the service is to be exposed. +The Aries Remote Service Admin (RSA) project allows regular OSGi services to be transparently accessed remotely. +OSGi services can be marked for export by adding the service property `service.exported.interfaces=*`. +Various other properties can be used to customize how the service is to be exposed. -For more information, check out section "122 JPA Service Specification Version 1.0" in the "OSGi Service Platform Enterprise Specification, Release 4, Version 4.2" available for public download from the http://www.osgi.org/Download/Release4V43[OSGi Alliance]. +For more information, see section 122 "Remote Service Admin Service Specification" +in the "OSGi Compendium Release 8" specification, available from the https://docs.osgi.org/specification/osgi.cmpn/8.0.0/[OSGi Working Group]. == Source -The Aries RSA source is in a separate https://git-wip-us.apache.org/repos/asf/aries-rsa.git[git repository aries-rsa] there is also a https://github.com/apache/aries-rsa[mirror on github]. +The Aries RSA source code is available on https://git.apache.org/repos/asf/aries-rsa.git[GitBox] Review Comment: let's set only the address on GH ########## modules/ROOT/pages/modules/rsa.adoc: ########## @@ -82,14 +111,17 @@ The example uses declarative services to publish and bind services. === Modules -* api : EchoService interface -* service : EchoService implementation -* consumer : Small consumer that uses the EchoService +* api - the EchoService interface Review Comment: btw have you tried to install this tutorial and test it on karaf? ########## modules/ROOT/pages/modules/rsa.adoc: ########## @@ -1,76 +1,105 @@ = RSA (Remote Service Admin) -The Aries Remote Service Admin (RSA) project allows to transparently use OSGi services for remote communication. -OSGi services can be marked for export by adding a service property `service.exported.interfaces=*`. -Various other properties can be used to customize how the service is to be exposed. +The Aries Remote Service Admin (RSA) project allows regular OSGi services to be transparently accessed remotely. +OSGi services can be marked for export by adding the service property `service.exported.interfaces=*`. +Various other properties can be used to customize how the service is to be exposed. -For more information, check out section "122 JPA Service Specification Version 1.0" in the "OSGi Service Platform Enterprise Specification, Release 4, Version 4.2" available for public download from the http://www.osgi.org/Download/Release4V43[OSGi Alliance]. +For more information, see section 122 "Remote Service Admin Service Specification" +in the "OSGi Compendium Release 8" specification, available from the https://docs.osgi.org/specification/osgi.cmpn/8.0.0/[OSGi Working Group]. == Source -The Aries RSA source is in a separate https://git-wip-us.apache.org/repos/asf/aries-rsa.git[git repository aries-rsa] there is also a https://github.com/apache/aries-rsa[mirror on github]. +The Aries RSA source code is available on https://git.apache.org/repos/asf/aries-rsa.git[GitBox] +or https://github.com/apache/aries-rsa[GitHub]. == Build - mvn clean install + ./mvnw clean install == Architecture image::https://cwiki.apache.org/confluence/download/attachments/30739778/remote-service-admin-spec.png?version=2&modificationDate=1362365400000&api=v2[Remote Service Admin Architecture overview] -=== Some definitions +=== Some Definitions -* EndpointDescription Describes a remote service using service interfaces, remote url and all other properties to import the remote service. -* EndpointListener a service that is to be notified when remote Endpoints described by OSGi filters appear or disappear. +* Export - the process of making a local service available for access by remote hosts. +* Import - the process of making a remote service available for access by local services, + by creating a local proxy whose invocation is sent to the remote service behind the scenes. +* EndpointDescription - describes a remote service via a set of properties containing both the original + service properties and all metadata needed to reach and use it remotely + (e.g. the exported interfaces, URI, transport details, etc). +* EndpointEventListener - an interface implemented by services that are used either to notify + (on the exporting side) or be notified about (on the importing side) remote endpoints that + appear or disappear (filtered by scope as needed). === https://github.com/apache/aries-rsa/tree/master/topology-manager[Topology Manager] -* Listens to local services and decides which to expose. -It can also add properties to change the way services are exposed. -For the services to be exported it calls RemoteServiceAdmin.exportService to do the actual export. -Then notifies EndpointListeners about the new Endpoint. -* Listens for service requests from consumers and creates EndpointListeners for these interests. +The "brain" that manages imports and exports: -The TopologyManager by default exposes all suitably marked local services for export and imports all service interests with matching remote Endpoints. +* Listens to local services and decides which to export and how to do so based on their properties. + It calls RemoteServiceAdmin.exportService to perform the actual export, Review Comment: let's make class names, functions names in whole the file in code blocks like `ClassName.function` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
