pitrou commented on a change in pull request #172:
URL: https://github.com/apache/arrow-site/pull/172#discussion_r765590787
##########
File path: _data/committers.yml
##########
@@ -46,7 +46,15 @@
- name: Antoine Pitrou
role: PMC
alias: apitrou
- affiliation: Independent / Ursa Computing
+ affiliation: Independent / Voltron Data
Review comment:
```suggestion
affiliation: Voltron Data
```
##########
File path: _data/committers.yml
##########
@@ -139,14 +159,14 @@
role: PMC
alias: tdunning
affiliation: MapR
+- name: Todd Lipcon
+ role: PMC
+ alias: todd
+ affiliation: Google
- name: Uwe L. Korn
role: PMC
alias: uwe
affiliation: Quantco
-- name: Ben Kietzman
- role: PMC
- alias: bkietz
- affiliation: Ursa Computing
Review comment:
Nit, but could you add a blank line between the PMCs and the committers
here?
##########
File path: scripts/check_committers.py
##########
@@ -32,7 +32,7 @@
git_root = os.path.abspath(os.path.dirname(os.path.dirname(__file__)))
-
+git_root = os.path.join(git_root,"../")
Review comment:
This breaks the script for me:
```bash
$ .venv/bin/python scripts/check_committers.py
Traceback (most recent call last):
File "scripts/check_committers.py", line 72, in <module>
local_roster = get_local_roster()
File "scripts/check_committers.py", line 55, in get_local_roster
with open(committers_yaml, "r") as f:
FileNotFoundError: [Errno 2] No such file or directory:
'/home/antoine/arrow/site/../_data/committers.yml'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
