pitrou commented on a change in pull request #172:
URL: https://github.com/apache/arrow-site/pull/172#discussion_r765770534
##########
File path: scripts/check_committers.py
##########
@@ -64,18 +74,24 @@ def get_local_roster():
elif role == 'Committer':
committers.add(uid)
else:
- raise ValueError(f"Invalid role {role!r} for {uid}")
+ raise ValueError(f"Invalid role {role!r} for {uid}")
return Roster(committers, pmcs)
-
if __name__ == "__main__":
+ with open(committers_yaml, "r") as f:
+ d = yaml.safe_load(f)
Review comment:
It doesn't seem this variable is used, is it?
##########
File path: scripts/check_committers.py
##########
@@ -64,18 +74,24 @@ def get_local_roster():
elif role == 'Committer':
committers.add(uid)
else:
- raise ValueError(f"Invalid role {role!r} for {uid}")
+ raise ValueError(f"Invalid role {role!r} for {uid}")
Review comment:
Is this change deliberate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
