kevingurney commented on code in PR #326:
URL: https://github.com/apache/arrow-site/pull/326#discussion_r1124180233
##########
.github/workflows/deploy.yml:
##########
@@ -27,17 +27,33 @@ jobs:
deploy:
name: Deploy
runs-on: ubuntu-latest
+ container:
+ image: ubuntu:latest
steps:
- - uses: actions/checkout@v2
- - uses: ruby/setup-ruby@v1
+ - name: Update packages
+ run: |
+ apt-get update -qq
+ - name: Install dependencies
+ run: |
+ apt-get install -qq -y jq rsync git libyaml-0-2 npm
+ - name: Checkout git repository
+ uses: actions/checkout@v3
+ - name: Set GitHub workspace as git safe.directory # Required to work
around: https://github.com/actions/checkout/issues/766
+ run: |
+ git config --global --add safe.directory "$GITHUB_WORKSPACE"
+ - name: Install Ruby
+ uses: ruby/setup-ruby@v1
with:
- bundler-cache: true
- - uses: actions/setup-node@v2
+ bundler-cache: true
+ env:
+ ImageOS: ubuntu22
+ - name: Install Node.js
+ uses: actions/setup-node@v2
Review Comment:
That makes sense. I'll replace `lts/hydrogen` with `lts/*` in `.nvmrc`.
I've also increased the Node.js `"engines"` requirement in `package.json` to
`18.14.2` to encourage contributors to use a more recent version of Node.js
while developing.
As you alluded to, the fallback `md4` implementation seems to be working.
So, if we are OK with Webpack using an outdated hashing strategy, then I think
we can proceed with these changes for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
