kevingurney commented on code in PR #326:
URL: https://github.com/apache/arrow-site/pull/326#discussion_r1124110330
##########
.github/workflows/deploy.yml:
##########
@@ -27,17 +27,33 @@ jobs:
deploy:
name: Deploy
runs-on: ubuntu-latest
+ container:
+ image: ubuntu:latest
steps:
- - uses: actions/checkout@v2
- - uses: ruby/setup-ruby@v1
+ - name: Update packages
+ run: |
+ apt-get update -qq
+ - name: Install dependencies
+ run: |
+ apt-get install -qq -y jq rsync git libyaml-0-2 npm
+ - name: Checkout git repository
+ uses: actions/checkout@v3
+ - name: Set GitHub workspace as git safe.directory # Required to work
around: https://github.com/actions/checkout/issues/766
+ run: |
+ git config --global --add safe.directory "$GITHUB_WORKSPACE"
+ - name: Install Ruby
+ uses: ruby/setup-ruby@v1
with:
- bundler-cache: true
- - uses: actions/setup-node@v2
+ bundler-cache: true
+ env:
+ ImageOS: ubuntu22
+ - name: Install Node.js
+ uses: actions/setup-node@v2
Review Comment:
You are absolutely right. Thank you for catching this @kou!
It looks like the [version of Node.js in the Ubuntu 22.04 package
repositories is version
`12.22.9`](https://packages.ubuntu.com/jammy/web/nodejs). I had falsely assumed
it would be version 16 since that was the version used by the `ubuntu-latest`
runner prior to the breaking upgrade to Node 18.
I should have looked at the build log more closely to confirm this. My
apologies for this oversight.
Moving forward:
1. I think we should explicitly specify the version of Node.js we want to
use to avoid any ambiguity. This is [recommended in the `actions/setup-node`
documentation](https://github.com/actions/setup-node#usage):
> The node-version input is optional. If not supplied, the node version from
PATH will be used. However, it is recommended to always specify Node.js version
and don't rely on the system one.
2. I agree that we should use `v3` of `actions/setup-node`.
3. Updating Webpack with `npm install webpack` seems like a good idea, too.
However, this may require us to specify the `output.hashFunction` in the
Webpack config too. I'll investigate this further.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
