This is an automated email from the ASF dual-hosted git repository.
lidavidm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-adbc.git
The following commit(s) were added to refs/heads/main by this push:
new d068ba2d15 chore: move JNI verification test selection into Java test
(#4943)
d068ba2d15 is described below
commit d068ba2d15208521aa8e8b3b03ad143fd5807497
Author: Bryce Mecum <[email protected]>
AuthorDate: Mon Oct 26 16:14:24 2026 -0700
chore: move JNI verification test selection into Java test (#4943)
This was put into the bash script in
https://github.com/apache/arrow-adbc/pull/4937 for the purpose of the
release but now we can move it into the Java test code.
---
dev/release/verify-release-candidate.sh | 7 -------
.../apache/arrow/adbc/verify/VerifyReleaseCandidateTest.java | 11 +++++++++++
2 files changed, 11 insertions(+), 7 deletions(-)
diff --git a/dev/release/verify-release-candidate.sh
b/dev/release/verify-release-candidate.sh
index 3c8e123f28..c59fa0fdc2 100755
--- a/dev/release/verify-release-candidate.sh
+++ b/dev/release/verify-release-candidate.sh
@@ -966,14 +966,7 @@ print(version.text)
"-Djavadoc=${javadoc_path}"
done
- local test_arguments=()
- if [[ "$(uname)" == "Darwin" && "$(uname -m)" == "x86_64" ]]; then
- show_info "Skipping testDriverJni: JNI binaries are not available for
macOS/x86_64"
- test_arguments+=('-Dtest=!VerifyReleaseCandidateTest#testDriverJni')
- fi
-
mvn "${maven_arguments[@]}" test \
- "${test_arguments[@]}" \
"-Dadbc.version=${java_version}" \
-f "${SOURCE_DIR}/verify/java/pom.xml"
}
diff --git
a/dev/release/verify/java/src/test/java/org/apache/arrow/adbc/verify/VerifyReleaseCandidateTest.java
b/dev/release/verify/java/src/test/java/org/apache/arrow/adbc/verify/VerifyReleaseCandidateTest.java
index 83f6d5512d..03c4abfcc2 100644
---
a/dev/release/verify/java/src/test/java/org/apache/arrow/adbc/verify/VerifyReleaseCandidateTest.java
+++
b/dev/release/verify/java/src/test/java/org/apache/arrow/adbc/verify/VerifyReleaseCandidateTest.java
@@ -85,6 +85,17 @@ class VerifyReleaseCandidateTest {
@Test
void testDriverJni() {
var driver = new JniDriver(allocator);
+ if (OS.MAC.isCurrentOs() &&
"x86_64".equalsIgnoreCase(System.getProperty("os.arch"))) {
+ // JNI binaries are not available for macOS x86_64.
+ ExceptionInInitializerError exception =
+ assertThrows(
+ ExceptionInInitializerError.class, () ->
driver.load().driver("nonexistent").open());
+ assertThat(exception)
+ .hasRootCauseInstanceOf(RuntimeException.class)
+ .hasRootCauseMessage("ADBC JNI driver not supported on architecture
x86_64");
+ return;
+ }
+
if (OS.WINDOWS.isCurrentOs() &&
"aarch64".equalsIgnoreCase(System.getProperty("os.arch"))) {
// JNI binaries are not available for Windows ARM64.
ExceptionInInitializerError exception =