This is an automated email from the ASF dual-hosted git repository.
lidavidm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-adbc.git
The following commit(s) were added to refs/heads/main by this push:
new 6c1bf4a70a chore(javascript): format packages after we run napi (#4959)
6c1bf4a70a is described below
commit 6c1bf4a70af6a64bd5725ed6f64ea27c78ebcf16
Author: Bryce Mecum <[email protected]>
AuthorDate: Mon Oct 26 16:19:26 2026 -0700
chore(javascript): format packages after we run napi (#4959)
In https://github.com/apache/arrow-adbc/pull/4954 we saw the
Lint/CheckJS job fail:
```
Checking formatting...
[warn] npm/darwin-arm64/package.json
[warn] npm/darwin-x64/package.json
[warn] npm/linux-arm64-gnu/package.json
[warn] npm/linux-x64-gnu/package.json
[warn] npm/win32-arm64-msvc/package.json
[warn] npm/win32-x64-msvc/package.json
[warn] Code style issues found in 6 files. Run Prettier with --write to fix.
Error: Process completed with exit code 1.
```
In dev/release/utils-prepare.sh we run `npx --yes napi version` which,
when it writes out new `package.json` files, doesn't add trailing
newlines. I think we should reformat after we run `napi` so this PR adds
an `npm run fix` after we run `napi version` so the result of `napi`
passes our lint step.
---
dev/release/utils-prepare.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/dev/release/utils-prepare.sh b/dev/release/utils-prepare.sh
index bfb64db108..1caf191b00 100644
--- a/dev/release/utils-prepare.sh
+++ b/dev/release/utils-prepare.sh
@@ -168,6 +168,7 @@ update_versions() {
package.json
rm package.json.bak
npx --yes napi version
+ npm run fix # napi doesn't add trailing newlines, so reformat now
sed -i.bak -E "s/^version = \".+\"/version = \"${js_version}\"/" Cargo.toml
rm Cargo.toml.bak
npm i --package-lock-only
