guixiaowen commented on code in PR #1438:
URL: https://github.com/apache/auron/pull/1438#discussion_r2426673399
##########
spark-extension/src/main/scala/org/apache/spark/sql/auron/AuronConverters.scala:
##########
@@ -183,11 +183,8 @@ object AuronConverters extends Logging {
def convertSparkPlan(exec: SparkPlan): SparkPlan = {
exec match {
- case e: ShuffleExchangeExec => tryConvert(e, convertShuffleExchangeExec)
- case e: BroadcastExchangeExec if enableBroadcastExchange =>
- tryConvert(e, convertBroadcastExchangeExec)
case e: ShuffleExchangeExec if enableExchange => tryConvert(e,
convertShuffleExchangeExec)
Review Comment:
> Could you please fix this typo? change `enableShuffleExechange ` to
`enableShuffleExchange `
>
>
https://github.com/apache/auron/blob/47de780e9619860a79e7d0a2ef113aa3ebf6f6a4/spark-extension/src/main/scala/org/apache/spark/sql/auron/AuronConverters.scala#L138
@wForget DONE
##########
spark-extension/src/main/scala/org/apache/spark/sql/auron/AuronConverters.scala:
##########
@@ -183,11 +183,8 @@ object AuronConverters extends Logging {
def convertSparkPlan(exec: SparkPlan): SparkPlan = {
exec match {
- case e: ShuffleExchangeExec => tryConvert(e, convertShuffleExchangeExec)
- case e: BroadcastExchangeExec if enableBroadcastExchange =>
- tryConvert(e, convertBroadcastExchangeExec)
case e: ShuffleExchangeExec if enableExchange => tryConvert(e,
convertShuffleExchangeExec)
Review Comment:
> The `enableExchange` method name is confusing. I suggest changing it to
`enabledAuronShuffleExchange` or just keep one `enableShuffleExchange` method.
@wForget DONE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
