wForget commented on code in PR #1438:
URL: https://github.com/apache/auron/pull/1438#discussion_r2426360656
##########
spark-extension/src/main/scala/org/apache/spark/sql/auron/AuronConverters.scala:
##########
@@ -183,11 +183,8 @@ object AuronConverters extends Logging {
def convertSparkPlan(exec: SparkPlan): SparkPlan = {
exec match {
- case e: ShuffleExchangeExec => tryConvert(e, convertShuffleExchangeExec)
- case e: BroadcastExchangeExec if enableBroadcastExchange =>
- tryConvert(e, convertBroadcastExchangeExec)
case e: ShuffleExchangeExec if enableExchange => tryConvert(e,
convertShuffleExchangeExec)
Review Comment:
> > Can we change the `enableExchange` method name to
`enableShuffleExchange`?
>
> @wForget Thank you very much for reviewing the code, but it won’t work
because there’s already a method with the same name that checks the variable.
Oo, I see, and it seems to have typo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
