Tartarus0zm commented on code in PR #1532:
URL: https://github.com/apache/auron/pull/1532#discussion_r2472167042
##########
spark-extension/src/main/scala/org/apache/spark/sql/auron/AuronConverters.scala:
##########
@@ -140,6 +143,10 @@ object AuronConverters extends Logging {
getBooleanConf("spark.auron.enable.shuffleExchange", defaultValue = true)
private val extConvertProviders =
ServiceLoader.load(classOf[AuronConvertProvider]).asScala
+
+ private val sparkAuronConfig: AuronConfiguration =
+ AuronAdaptor.getInstance.getAuronConfiguration
Review Comment:
@SteNicholas The API `getAuronConfiguration` already exists within the
`AuronAdaptor`. Since the `AuronAdaptor ` use the singleton pattern, the
`getInstance` API must be called first each time.
Let's discuss this issue in https://github.com/apache/auron/issues/1535.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
