Tartarus0zm commented on code in PR #1532:
URL: https://github.com/apache/auron/pull/1532#discussion_r2472242807
##########
spark-extension/src/main/scala/org/apache/spark/sql/auron/NativeConverters.scala:
##########
@@ -1192,9 +1202,8 @@ object NativeConverters extends Logging {
.setInputSchema(NativeConverters.convertSchema(paramsSchema)))
aggBuilder.addAllChildren(convertedChildren.keys.asJava)
} else {
- throw new NotImplementedError(
- s"unsupported aggregate expression: (${e.getClass})," +
- s" set ${AuronConf.UDAF_FALLBACK_ENABLE.key} true to enable UDAF
fallbacking")
+ throw new NotImplementedError(s"unsupported aggregate expression:
(${e.getClass})," +
Review Comment:
I have Updated. PTAL
##########
spark-extension/src/main/scala/org/apache/spark/sql/auron/NativeConverters.scala:
##########
@@ -1192,9 +1202,8 @@ object NativeConverters extends Logging {
.setInputSchema(NativeConverters.convertSchema(paramsSchema)))
aggBuilder.addAllChildren(convertedChildren.keys.asJava)
} else {
- throw new NotImplementedError(
- s"unsupported aggregate expression: (${e.getClass})," +
- s" set ${AuronConf.UDAF_FALLBACK_ENABLE.key} true to enable UDAF
fallbacking")
+ throw new NotImplementedError(s"unsupported aggregate expression:
(${e.getClass})," +
+ s" set ${SparkAuronConfiguration.UDAF_FALLBACK_ENABLE.key} true to
enable UDAF fallbacking")
Review Comment:
I have Updated. PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
