Re: [PR] [AURON #1595] Enforce skiptest=false to not miss failing UT [auron]

[via GitHub]

merrily01 commented on code in PR #1596:
URL: https://github.com/apache/auron/pull/1596#discussion_r2493147841


##########
.github/workflows/tpcds-reusable.yml:
##########
@@ -175,7 +175,7 @@ jobs:
             UNIFFLE_NUMBER="${UNIFFLE_NUMBER#uniffle-}"
           fi
           
-          CMD="./auron-build.sh --pre --sparkver $SPARK_NUMBER --scalaver ${{ 
inputs.scalaver }}"
+          CMD="./auron-build.sh --pre --sparkver $SPARK_NUMBER --scalaver ${{ 
inputs.scalaver }} --skiptests false"

Review Comment:
   > I understand the concern, but in my opinion, even with a separate 
pipeline, we’ll still be testing with different profiles in a format similar to 
the framework already provided by the TPC-DS tests. Here’s why I don’t think 
this is a major issue:
   > 
   > 1. The current number of tests is quite low
   > 2. All testing happens during the Build Auron JAR step in the pipeline 
(picture). While this might slightly delay the start of TPC-DS queries, it 
shouldn’t trigger false regression alarms
   > 3. At this stage, I’m not sure it makes sense to introduce another set of 
n jobs that essentially duplicate what the Build Auron JAR step already does
   > 
   > <img alt="image" width="837" height="107" 
src="https://private-user-images.githubusercontent.com/47700876/509638677-ddb02f53-f300-4831-952c-826347956b5f.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjIzMjMwNzYsIm5iZiI6MTc2MjMyMjc3NiwicGF0aCI6Ii80NzcwMDg3Ni81MDk2Mzg2NzctZGRiMDJmNTMtZjMwMC00ODMxLTk1MmMtODI2MzQ3OTU2YjVmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTExMDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUxMTA1VDA2MDYxNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ1ZWJiM2ZmOGU2ZTZhM2UyMzcwZDFjNzVmZGRlOGY0OGFjMTUxMTMxODI3YTcwN2Q2YjJhNjY1N2IwZTUwMmMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.2-TfFQ67foyxr1pd4ou0IJBMVpEMvtjaOeiRXcsLRJM";>
   
   Thanks for the explanation.
   That makes sense to me — let’s keep it this way for now, but we can 
reconsider if the test suite expands or starts affecting TPC-DS performance. 
@richox 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@auron.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org