ShreyeshArangath commented on code in PR #1596:
URL: https://github.com/apache/auron/pull/1596#discussion_r2547503183
##########
spark-extension-shims-spark/src/test/scala/org/apache/spark/sql/auron/AuronFunctionSuite.scala:
##########
@@ -498,42 +500,51 @@ class AuronFunctionSuite
}
}
- test("test function IsNaN") {
- withTable("t1") {
- sql(
- "create table test_is_nan using parquet as select cast('NaN' as
double) as c1, cast('NaN' as float) as c2, log(-3) as c3, cast(null as double)
as c4, 5.5f as c5")
- val functions =
- """
- |select
- | isnan(c1),
- | isnan(c2),
- | isnan(c3),
- | isnan(c4),
- | isnan(c5)
- |from
- | test_is_nan
+ ignore("DISABLED: isNaN native semantics mismatch (null -> false)") {
Review Comment:
Added this because the PR required to support isNaN will likely involve
modifying pieces that will take away from the intent of this PR.
isnan is broken right now, and it made sense to leave it and fix forward.
The fix will be tracked as part of https://github.com/apache/auron/issues/1646
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
