yew1eb commented on PR #1620: URL: https://github.com/apache/auron/pull/1620#issuecomment-3515811507
> Thank you for your contribution. You can add a test to verify whether cases like `NativeShuffleExchangeExec.write` have been fixed. @Tartarus0zm A direct test for `NativeShuffleExchangeExec.write` is ideal but hard to reproduce in unit tests — the local Spark cluster runs driver and executor in the same JVM, so static objects like `AuronAdaptor.getInstance()` are initialized early during driver planning, preventing the executor-side null → NPE failure seen in #1602. We added test units to ensure getInstance() never returns null. I also deployed the fix to production and re-ran the same SQL — the NoClassDefFoundError no longer occurs. Any suggestions for a stronger test? Happy to improve if there's a better approach! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
