yew1eb commented on code in PR #1620:
URL: https://github.com/apache/auron/pull/1620#discussion_r2513919188
##########
spark-extension/src/main/java/org/apache/auron/spark/configuration/SparkAuronConfiguration.java:
##########
@@ -114,14 +113,7 @@ public class SparkAuronConfiguration extends
AuronConfiguration {
"auron.partialAggSkipping.minRows")
.description("minimum number of rows to trigger partial aggregate
skipping.")
.intType()
- .defaultValue(
Review Comment:
@Tartarus0zm
this is a design flaw in `SparkAuronConfiguration`. Static initialization
must not depend on runtime singletons like
`AuronAdaptor.getInstance().getAuronConfiguration()`. because:
+ It creates a circular dependency:
`SparkAuronConfiguration → AuronAdaptor → SparkAuronConfiguration`
+ Static defaults must be pure constants
In this PR, remove this code. Then we’ll open a follow-up issue to properly
redesign SparkAuronConfiguration. What do you think?”
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
