xumingming commented on code in PR #1731:
URL: https://github.com/apache/auron/pull/1731#discussion_r2609157482


##########
thirdparty/auron-celeborn-0.6/src/main/scala/org/apache/spark/sql/execution/auron/shuffle/celeborn/AuronCelebornShuffleWriter.scala:
##########
@@ -76,4 +76,19 @@ class AuronCelebornShuffleWriter[K, V](
       Shims.get
         .getMapStatus(blockManagerId, 
celebornPartitionWriter.getPartitionLengthMap, mapId))
   }
+
+  // Override stop to use partition length map directly instead of rssStop's 
mapStatus
+  // because celeborn writer doesn't populate partition sizes correctly when 
using native writer

Review Comment:
   > celeborn writer doesn't populate partition sizes correctly when using 
native writer
   
   Two questions here:
   
   1. Why the partition sizes are not populated correctly?
   2. Can we fix the issue by correctly populating partition sizes instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to