cxzl25 commented on code in PR #1731:
URL: https://github.com/apache/auron/pull/1731#discussion_r2609237061
##########
thirdparty/auron-celeborn-0.6/src/main/scala/org/apache/spark/sql/execution/auron/shuffle/celeborn/AuronCelebornShuffleWriter.scala:
##########
@@ -76,4 +76,19 @@ class AuronCelebornShuffleWriter[K, V](
Shims.get
.getMapStatus(blockManagerId,
celebornPartitionWriter.getPartitionLengthMap, mapId))
}
+
+ // Override stop to use partition length map directly instead of rssStop's
mapStatus
+ // because celeborn writer doesn't populate partition sizes correctly when
using native writer
+ override def stop(success: Boolean): Option[MapStatus] = {
+ if (!success) {
+ return None
+ }
+
+ // Always use getPartitionLengthMap for Celeborn to get correct partition
sizes
+ val blockManagerId = SparkEnv.get.blockManager.shuffleServerId
+ Some(Shims.get.getMapStatus(
+ blockManagerId,
+ celebornPartitionWriter.getPartitionLengthMap,
Review Comment:
Is this logic already handled in the rssStop method? What did I miss?
https://github.com/apache/auron/pull/1133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
