weiqingy commented on code in PR #2371:
URL: https://github.com/apache/auron/pull/2371#discussion_r3611991416
##########
auron-build.sh:
##########
@@ -165,6 +168,19 @@ while [[ $# -gt 0 ]]; do
exit 1
fi
;;
+ --platform)
+ if [[ -n "$2" && "$2" != -* ]]; then
+ DOCKER_PLATFORM="$2"
+ if [[ ! "$DOCKER_PLATFORM" =~
^[a-z0-9_.-]+/[a-z0-9_.-]+(/[a-z0-9_.-]+)?$ ]]; then
Review Comment:
👍 The CLI surface is gone cleanly.
Nit: three lines from the flag are still in place —
`DEFAULT_DOCKER_PLATFORM` (`:42`), `DOCKER_PLATFORM="$DEFAULT_DOCKER_PLATFORM"`
(`:129`), and `export AURON_DOCKER_PLATFORM="$DOCKER_PLATFORM"` (`:571`).
Nothing sets `DOCKER_PLATFORM` any more and the export is unconditional, so
compose always receives `linux/amd64` and the
`${AURON_DOCKER_PLATFORM:-linux/amd64}` fallback never fires — the knob is
inert as shipped. Dropping all three leaves the compose line as the single
source of the default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
