weiqingy commented on code in PR #2371:
URL: https://github.com/apache/auron/pull/2371#discussion_r3607641629
##########
auron-build.sh:
##########
@@ -165,6 +168,19 @@ while [[ $# -gt 0 ]]; do
exit 1
fi
;;
+ --platform)
+ if [[ -n "$2" && "$2" != -* ]]; then
+ DOCKER_PLATFORM="$2"
+ if [[ ! "$DOCKER_PLATFORM" =~
^[a-z0-9_.-]+/[a-z0-9_.-]+(/[a-z0-9_.-]+)?$ ]]; then
Review Comment:
Yeah, makes sense. There's no arm64 build path in these images today — the
toolchain's pinned to x86_64 — so `--platform` really only has the one value
for now. Two options come to mind, and I’m good either way:
- Drop `--platform` and lean on the compose default
(`${AURON_DOCKER_PLATFORM:-linux/amd64}`), then add the flag back once there's
more than one platform worth selecting; or
- Keep --platform, but make it a true opt-in — only export
AURON_DOCKER_PLATFORM when the flag is passed, and let the compose
:-linux/amd64 be the default. That keeps the discoverable knob and lets an
ambient AURON_DOCKER_PLATFORM still win when the flag is absent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
