XorSum commented on code in PR #2404:
URL: https://github.com/apache/auron/pull/2404#discussion_r3612320749
##########
spark-extension-shims-spark/src/test/scala/org/apache/spark/sql/AuronQueryTest.scala:
##########
@@ -19,17 +19,19 @@ package org.apache.spark.sql
import org.apache.spark.sql.auron.NativeSupports
import org.apache.spark.sql.execution.{LeafExecNode, SparkPlan, UnaryExecNode}
import org.apache.spark.sql.execution.adaptive.AdaptiveSparkPlanHelper
-import org.apache.spark.sql.test.SQLTestUtils
import org.scalatest.BeforeAndAfterEach
+import org.apache.auron.sparkverExcludeParents
+
/**
- * Base test class under org.apache.spark.sql to use package-private
[[SQLTestUtils]]; extends
- * [[QueryTest]] for comparisons and checks.
+ * Base test class under org.apache.spark.sql to extends [[QueryTest]] for
comparisons and checks.
+ * Before spark-4.1 also extends package-private
[[org.apache.spark.sql.test.SQLTestUtils]].
*/
+@sparkverExcludeParents("4.2", "org.apache.spark.sql.test.SQLTestUtils")
abstract class AuronQueryTest
extends QueryTest
- with SQLTestUtils
with BeforeAndAfterEach
+ with org.apache.spark.sql.test.SQLTestUtils
with AdaptiveSparkPlanHelper {
Review Comment:
`SQLTestUtils` is deprecated since 4.2.0, and we should use `QueryTest`
directly instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
