slfan1989 commented on code in PR #2404:
URL: https://github.com/apache/auron/pull/2404#discussion_r3696874905
##########
pom.xml:
##########
@@ -1154,6 +1154,64 @@
</build>
</profile>
+ <profile>
+ <id>spark-4.2</id>
+ <properties>
+ <shimName>spark-4.2</shimName>
+ <scalaTestVersion>3.2.9</scalaTestVersion>
+ <sparkVersion>4.2.0</sparkVersion>
+ <parquetVersion>1.17.0</parquetVersion>
+ <shortSparkVersion>4.2</shortSparkVersion>
+ <nettyVersion>4.2.13.Final</nettyVersion>
+ </properties>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <version>${maven-enforcer-plugin.version}</version>
+ <executions>
+ <execution>
+ <id>spark42-enforce-java-scala-version</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <configuration>
+ <rules>
+ <!-- Spark 4.1 requires JDK 17+ and Scala 2.13.x -->
Review Comment:
Should this be Spark 4.2?
##########
auron-build.sh:
##########
@@ -30,7 +30,7 @@
# Define constants for supported component versions
# -----------------------------------------------------------------------------
SUPPORTED_OS_IMAGES=("centos7" "ubuntu24" "rockylinux8" "debian11"
"azurelinux3")
-SUPPORTED_SPARK_VERSIONS=("3.0" "3.1" "3.2" "3.3" "3.4" "3.5" "4.0" "4.1")
+SUPPORTED_SPARK_VERSIONS=("3.0" "3.1" "3.2" "3.3" "3.4" "3.5" "4.0" "4.1"
"4.2")
Review Comment:
Thanks for adding Spark 4.2 support! Could you also update CONTRIBUTING.md?
Its supported-version list and compatibility matrix currently stop at Spark
4.1, and the document requires them to be updated when support changes. Please
add Spark 4.2 with Scala 2.13/JDK 17+ and note that Iceberg and Hudi are
unsupported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]