Copilot commented on code in PR #2408:
URL: https://github.com/apache/auron/pull/2408#discussion_r3618453456
##########
auron-build.sh:
##########
@@ -72,16 +72,33 @@ print_help() {
echo "Examples:"
echo " $0 --pre --sparkver ${SUPPORTED_SPARK_VERSIONS[*]: -1}" \
"--scalaver ${SUPPORTED_SCALA_VERSIONS[*]: -1} -DskipBuildNative"
- echo " $0 --docker true --image ${SUPPORTED_OS_IMAGES[*]:0:1}" \
+ echo " # Spark 3.5 with all supported third-party integrations"
+ echo " $0 --docker true --image rockylinux8" \
"--clean true --skiptests true --release" \
- "--sparkver ${SUPPORTED_SPARK_VERSIONS[*]: -1}" \
+ "--sparkver 3.5 --scalaver 2.12" \
"--flinkver ${SUPPORTED_FLINK_VERSIONS[*]: -1}" \
- "--scalaver ${SUPPORTED_SCALA_VERSIONS[*]: -1}" \
"--celeborn ${SUPPORTED_CELEBORN_VERSIONS[*]: -1}" \
"--uniffle ${SUPPORTED_UNIFFLE_VERSIONS[*]: -1}" \
"--paimon ${SUPPORTED_PAIMON_VERSIONS[*]: -1}" \
"--iceberg ${SUPPORTED_ICEBERG_VERSIONS[*]: -1}" \
"--hudi ${SUPPORTED_HUDI_VERSIONS[*]: -1}"
Review Comment:
The Spark 3.5 Docker example picks the *last* supported Iceberg/Hudi
versions via `${SUPPORTED_*_VERSIONS[*]: -1}`. That makes the help text
sensitive to array ordering and could accidentally print an incompatible
integration version when multiple versions become supported (the new
compatibility matrix documents specific compatible versions per Spark release).
Consider pinning the example to the documented versions instead of selecting
the last element.
##########
auron-build.sh:
##########
@@ -72,16 +72,33 @@ print_help() {
echo "Examples:"
echo " $0 --pre --sparkver ${SUPPORTED_SPARK_VERSIONS[*]: -1}" \
"--scalaver ${SUPPORTED_SCALA_VERSIONS[*]: -1} -DskipBuildNative"
- echo " $0 --docker true --image ${SUPPORTED_OS_IMAGES[*]:0:1}" \
+ echo " # Spark 3.5 with all supported third-party integrations"
+ echo " $0 --docker true --image rockylinux8" \
"--clean true --skiptests true --release" \
- "--sparkver ${SUPPORTED_SPARK_VERSIONS[*]: -1}" \
+ "--sparkver 3.5 --scalaver 2.12" \
"--flinkver ${SUPPORTED_FLINK_VERSIONS[*]: -1}" \
- "--scalaver ${SUPPORTED_SCALA_VERSIONS[*]: -1}" \
"--celeborn ${SUPPORTED_CELEBORN_VERSIONS[*]: -1}" \
"--uniffle ${SUPPORTED_UNIFFLE_VERSIONS[*]: -1}" \
"--paimon ${SUPPORTED_PAIMON_VERSIONS[*]: -1}" \
"--iceberg ${SUPPORTED_ICEBERG_VERSIONS[*]: -1}" \
"--hudi ${SUPPORTED_HUDI_VERSIONS[*]: -1}"
+ echo " # Spark 4.0 (Hudi is not supported)"
+ echo " $0 --docker true --image rockylinux8" \
+ "--clean true --skiptests true --release" \
+ "--sparkver 4.0 --scalaver 2.13" \
+ "--flinkver ${SUPPORTED_FLINK_VERSIONS[*]: -1}" \
+ "--celeborn ${SUPPORTED_CELEBORN_VERSIONS[*]: -1}" \
+ "--uniffle ${SUPPORTED_UNIFFLE_VERSIONS[*]: -1}" \
+ "--paimon ${SUPPORTED_PAIMON_VERSIONS[*]: -1}" \
+ "--iceberg ${SUPPORTED_ICEBERG_VERSIONS[*]: -1}"
Review Comment:
Similarly, the Spark 4.0 Docker example selects the last supported Iceberg
version (`${SUPPORTED_ICEBERG_VERSIONS[*]: -1}`), which can drift from the
Spark-specific compatibility documented in CONTRIBUTING.md if additional
Iceberg versions are added later. Pinning this to the documented compatible
version keeps the help output stable and aligned with the matrix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
