Copilot commented on code in PR #2408:
URL: https://github.com/apache/auron/pull/2408#discussion_r3649558302
##########
CONTRIBUTING.md:
##########
@@ -130,6 +130,28 @@ Run `./auron-build.sh --help` to see all available
options, including:
- `--sparktests`: Run Spark integration tests
- `--threads`: Maven build threads (e.g. 1, 4, 1C). Defaults to
single-threaded local builds; Docker defaults to 8 unless overridden.
+### Build Compatibility Matrix
+
+The examples printed by `./auron-build.sh --help` use the following documented
build
+configurations based on the current compatibility checks. A dash (`—`) means
that the
+integration is not supported for that Spark version and must not be passed to
+`auron-build.sh`.
Review Comment:
`CONTRIBUTING.md` now documents Spark 4.0/4.1 in the compatibility matrix,
but the earlier `--sparkver` option bullet still lists only Spark 3.0–3.5. This
is inconsistent with both the matrix and `auron-build.sh` (which supports
4.0/4.1), and may mislead contributors.
##########
auron-build.sh:
##########
@@ -72,16 +72,33 @@ print_help() {
echo "Examples:"
echo " $0 --pre --sparkver ${SUPPORTED_SPARK_VERSIONS[*]: -1}" \
"--scalaver ${SUPPORTED_SCALA_VERSIONS[*]: -1} -DskipBuildNative"
- echo " $0 --docker true --image ${SUPPORTED_OS_IMAGES[*]:0:1}" \
+ echo " # Spark 3.5 with all supported third-party integrations"
+ echo " $0 --docker true --image rockylinux8" \
"--clean true --skiptests true --release" \
Review Comment:
The help text still advertises the default Docker image as `centos7`, but
`centos7` only installs JDK 8 (see `dev/docker-build/centos7/Dockerfile`), so
`--docker true --sparkver 4.x` will fail unless the user also overrides
`--image` to something like `rockylinux8`. Since this PR is making Spark 4.x
Docker guidance more explicit, it would help to also clarify this constraint in
the `--image` option description to prevent users from omitting `--image` and
hitting a hard-to-understand Java version failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
