weimingdiit commented on code in PR #2430:
URL: https://github.com/apache/auron/pull/2430#discussion_r3655414929
##########
thirdparty/auron-iceberg/src/test/scala/org/apache/auron/iceberg/AuronIcebergIntegrationSuite.scala:
##########
@@ -713,6 +713,92 @@ class AuronIcebergIntegrationSuite
}
}
+ test("iceberg changelog scan falls back for unsupported changelog
operations") {
+ withTable("local.db.t_changelog_unsupported_operation") {
+ withTempView("t_changelog_unsupported_operation_changes") {
+ sql("""
+ |create table local.db.t_changelog_unsupported_operation (id
int, v string)
+ |using iceberg
+ |tblproperties (
+ | 'format-version' = '2',
+ | 'write.delete.mode' = 'merge-on-read'
Review Comment:
Yes, that matches what is happening here. This case does not reach the
delete-file guard. The fallback comes from the changelog task-type check
because the changelog range contains both added-row tasks and non-added-row
tasks.
I renamed the test to "iceberg changelog scan falls back when a changelog
range mixes inserts and deletes", removed the misleading merge-on-read delete
property, and added assertions that the planned changelog tasks contain both
AddedRowsScanTask and non-AddedRowsScanTask. That makes the intended coverage
explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
