weiqingy commented on code in PR #2430:
URL: https://github.com/apache/auron/pull/2430#discussion_r3662843787


##########
thirdparty/auron-iceberg/src/test/scala/org/apache/auron/iceberg/AuronIcebergIntegrationSuite.scala:
##########
@@ -713,6 +713,92 @@ class AuronIcebergIntegrationSuite
     }
   }
 
+  test("iceberg changelog scan falls back for unsupported changelog 
operations") {
+    withTable("local.db.t_changelog_unsupported_operation") {
+      withTempView("t_changelog_unsupported_operation_changes") {
+        sql("""
+              |create table local.db.t_changelog_unsupported_operation (id 
int, v string)
+              |using iceberg
+              |tblproperties (
+              |  'format-version' = '2',
+              |  'write.delete.mode' = 'merge-on-read'

Review Comment:
   Thanks for the quick turnaround. My thread is closed.
   
   One thing I checked while looking at the split: the mixed-format test that 
stays doesn't have the same collision. #2435 keeps `formats.size > 1`, just 
over `nativeChangelogTasks` now, and its `toNativeChangelogDataFileTask` still 
accepts these `AddedRowsScanTask`s, so the range converts and then falls back 
on format either way. Nothing merge-order-dependent left as far as I can see.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to