weimingdiit commented on code in PR #2438:
URL: https://github.com/apache/auron/pull/2438#discussion_r3709177166
##########
spark-extension-shims-spark/src/test/scala/org/apache/auron/AuronQuerySuite.scala:
##########
@@ -883,6 +884,51 @@ class AuronQuerySuite extends AuronQueryTest with
BaseAuronSQLSuite with AuronSQ
}
}
+ test("native broadcast hash join supports inner residual condition") {
Review Comment:
@weiqingy @slfan1989 Thanks, agreed. This PR changes the accept side for
inner broadcast hash joins with residual conditions, but the reject side is
part of the contract as well.
I added a negative LEFT JOIN case with a broadcast hint and a residual
condition. The test checks the Spark answer and asserts that the executed plan
does not contain NativeBroadcastJoinExec, so non-inner broadcast hash joins
with residual conditions remain pinned to fallback.
I kept this to one non-inner case because all of the guards use the same
InnerLike predicate, so this should catch accidental broadening of the native
BHJ residual-condition path without expanding the test matrix unnecessarily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
