weiqingy commented on code in PR #2438:
URL: https://github.com/apache/auron/pull/2438#discussion_r3725094318
##########
spark-extension-shims-spark/src/test/scala/org/apache/auron/AuronQuerySuite.scala:
##########
@@ -883,6 +884,51 @@ class AuronQuerySuite extends AuronQueryTest with
BaseAuronSQLSuite with AuronSQ
}
}
+ test("native broadcast hash join supports inner residual condition") {
Review Comment:
Thanks, that closes my open item.
Worth noting the assertion is doing real work here rather than passing for
free: `LeftOuter` broadcast hash join is otherwise a supported native path
(`join_left_one` in `joins/test.rs` runs it green across both BHJ probe sides),
so the fallback in this test comes from the residual guard, not from the join
type being unsupported to begin with.
Nothing further from me. I'll leave the final call to the maintainers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
