This is an automated email from the ASF dual-hosted git repository.

blachniet pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/avro.git

commit 21698b9baa331e0f2506acb4c1b5408c1b84f071
Author: Brian Lachniet <blachn...@gmail.com>
AuthorDate: Sun Aug 18 11:23:08 2019 -0400

    AVRO-2454: Fix SA1600 - Elements should be documented
---
 lang/csharp/Avro.ruleset                              | 1 -
 lang/csharp/src/apache/main/Specific/ObjectCreator.cs | 2 ++
 lang/csharp/stylecop.json                             | 7 ++++++-
 3 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/lang/csharp/Avro.ruleset b/lang/csharp/Avro.ruleset
index 2a101e2..446f4a4 100644
--- a/lang/csharp/Avro.ruleset
+++ b/lang/csharp/Avro.ruleset
@@ -134,7 +134,6 @@
     <Rule Id="SA1516" Action="Info" />
     <Rule Id="SA1519" Action="Info" />
     <Rule Id="SA1520" Action="Info" />
-    <Rule Id="SA1600" Action="Info" />
     <Rule Id="SA1604" Action="Info" />
     <Rule Id="SA1606" Action="Info" />
     <Rule Id="SA1610" Action="Info" />
diff --git a/lang/csharp/src/apache/main/Specific/ObjectCreator.cs 
b/lang/csharp/src/apache/main/Specific/ObjectCreator.cs
index fe3f6ee..00a7f36 100644
--- a/lang/csharp/src/apache/main/Specific/ObjectCreator.cs
+++ b/lang/csharp/src/apache/main/Specific/ObjectCreator.cs
@@ -75,6 +75,7 @@ namespace Avro.Specific
 
 #pragma warning disable CS1591 // Missing XML comment for publicly visible 
type or member
 #pragma warning disable CA1034 // Nested types should not be visible
+#pragma warning disable SA1600 // Elements should be documented
         /// <summary>
         /// Obsolete: This will be removed from the public API in a future 
version.
         /// </summary>
@@ -117,6 +118,7 @@ namespace Avro.Specific
                 return !left.Equals(right);
             }
         }
+#pragma warning restore SA1600 // Elements should be documented
 #pragma warning restore CA1034 // Nested types should not be visible
 #pragma warning restore CS1591 // Missing XML comment for publicly visible 
type or member
 
diff --git a/lang/csharp/stylecop.json b/lang/csharp/stylecop.json
index 82e8819..8925591 100644
--- a/lang/csharp/stylecop.json
+++ b/lang/csharp/stylecop.json
@@ -3,7 +3,12 @@
   "settings": {
     "documentationRules": {
       "companyName": "Apache Software Foundation (ASF)",
-      "fileNamingConvention": "stylecop"
+      "fileNamingConvention": "stylecop",
+      "documentInterfaces": false,
+      "documentExposedElements": true,
+      "documentInternalElements": false,
+      "documentPrivateElements": false,
+      "documentPrivateFields": false
     },
     "indentation": {
       "indentationSize": 4,

Reply via email to