This is an automated email from the ASF dual-hosted git repository. blachniet pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/avro.git
commit 2641b45e2d61d718fd3301cf380ea829f2c0ae6a Author: Brian Lachniet <[email protected]> AuthorDate: Sun Aug 18 15:31:33 2019 -0400 AVRO-2454: Fix SA1611 - ElementParametersMustBeDocumented --- lang/csharp/Avro.ruleset | 1 - lang/csharp/src/apache/main/Generic/PreresolvingDatumReader.cs | 1 + lang/csharp/src/apache/main/Reflect/ArrayHelper.cs | 3 ++- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lang/csharp/Avro.ruleset b/lang/csharp/Avro.ruleset index a624c32..00e630d 100644 --- a/lang/csharp/Avro.ruleset +++ b/lang/csharp/Avro.ruleset @@ -133,7 +133,6 @@ <Rule Id="SA1516" Action="Info" /> <Rule Id="SA1519" Action="Info" /> <Rule Id="SA1520" Action="Info" /> - <Rule Id="SA1611" Action="Info" /> <Rule Id="SA1614" Action="Info" /> <Rule Id="SA1615" Action="Info" /> <Rule Id="SA1616" Action="Info" /> diff --git a/lang/csharp/src/apache/main/Generic/PreresolvingDatumReader.cs b/lang/csharp/src/apache/main/Generic/PreresolvingDatumReader.cs index b963618..8b0cffa 100644 --- a/lang/csharp/src/apache/main/Generic/PreresolvingDatumReader.cs +++ b/lang/csharp/src/apache/main/Generic/PreresolvingDatumReader.cs @@ -507,6 +507,7 @@ namespace Avro.Generic /// the Specific and Generic implementations. Used to avoid retrieving the existing /// value if it's not reusable. /// </summary> + /// <param name="tag">Schema type to test for reusability.</param> protected virtual bool IsReusable(Schema.Type tag) { return true; diff --git a/lang/csharp/src/apache/main/Reflect/ArrayHelper.cs b/lang/csharp/src/apache/main/Reflect/ArrayHelper.cs index afc6467..8e74235 100644 --- a/lang/csharp/src/apache/main/Reflect/ArrayHelper.cs +++ b/lang/csharp/src/apache/main/Reflect/ArrayHelper.cs @@ -58,7 +58,7 @@ namespace Avro.Reflect /// <summary> /// Add an element to the array. /// </summary> - /// <value></value> + /// <param name="o">Element to add to the array.</param> public virtual void Add(object o) { IList e = (IList)Enumerable; @@ -86,6 +86,7 @@ namespace Avro.Reflect /// <summary> /// Constructor /// </summary> + /// <param name="enumerable">Enumerable to initialize this helper with.</param> public ArrayHelper(IEnumerable enumerable) { Enumerable = enumerable;
