bchapuis commented on PR #659: URL: https://github.com/apache/incubator-baremaps/pull/659#issuecomment-1552892588
The code is well organized, well documented and reads really well! This is a great contribution, thank you. A minor comment regarding the CLI, it failed when I tried to use absolute paths: ``` ERROR: Folder '/Users/bchapuis/Projects/apache/baremaps/basemap/tests/integration' could not be found in current directory ``` Also, I expected to see some images poping in the test directory, and noticed that, in case of success, the files were cleaned. Personnally, I would prefer to always see the files by default. Finally, I think it would make sense to move the tool to the root directory and have if along side the other modules. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
