leonardcser commented on PR #659: URL: https://github.com/apache/incubator-baremaps/pull/659#issuecomment-1554216160
> A minor comment regarding the CLI, it failed when I tried to use absolute paths: Support for absolute paths can be added. > Also, I expected to see some images poping in the test directory, and noticed that, in case of success, the files were cleaned. Personnally, I would prefer to always see the files by default. In this case, what should the expected behaviour be like? Keep the old failing images, replace them with two identical, should the diff be replaced with a blank image? I suggest that if a tests succeeds, we can save one of the two `actual.png` or `expected.png` (as these would be both identical). > Finally, I think it would make sense to move the baremaps-renderer to the root directory and have it along side the other modules. What do you think? I agree and it make more sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
