Perdjesk commented on code in PR #772: URL: https://github.com/apache/incubator-baremaps/pull/772#discussion_r1315783111
########## baremaps-server/src/main/java/org/apache/baremaps/server/TilesetResource.java: ########## @@ -18,27 +18,28 @@ import javax.ws.rs.GET; import javax.ws.rs.Produces; import javax.ws.rs.core.MediaType; -import org.apache.baremaps.vectortile.tilejson.TileJSON; +import org.apache.baremaps.vectortile.tileset.Tileset; /** - * A resource that provides access to the tileset. + * A resource that provides access to the tileset file. Only suitable for development purposes, as + * it exposes SQL queries. Review Comment: Did a draft implementation that reverse the logic in order to allow fields instead of having to disallow them after the facts. https://github.com/apache/incubator-baremaps/pull/773 Motivation is similar to what was done in https://github.com/apache/incubator-baremaps/pull/658/files#diff-94ecab9df3004fae4fd05c3c610d8ef629f81cb775f72a53a19070c0293bc27cL62 to remove hiding of field with conditions after de-serialization, which could be error prone for newly added field in `tileset.json`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
