bchapuis commented on code in PR #772: URL: https://github.com/apache/incubator-baremaps/pull/772#discussion_r1316817690
########## baremaps-server/src/main/java/org/apache/baremaps/server/TilesetResource.java: ########## @@ -18,27 +18,28 @@ import javax.ws.rs.GET; import javax.ws.rs.Produces; import javax.ws.rs.core.MediaType; -import org.apache.baremaps.vectortile.tilejson.TileJSON; +import org.apache.baremaps.vectortile.tileset.Tileset; /** - * A resource that provides access to the tileset. + * A resource that provides access to the tileset file. Only suitable for development purposes, as + * it exposes SQL queries. Review Comment: Sorry, my answer was vague, let's add a bit of context. First, our implementation of tileJSON is partial and I think that adding an extension to the model will slow us down. Second, dev modes are usually [insecure](https://quarkus.io/guides/dev-mode-differences) and I think it is reasonable to assume that our users will not use it in production. Finally, an earlier version of the dev mode offered a maputnik integration and allowed the user to edit the style. I have not completely abandonned this idea (see #561) and we may introduce an API to edit local files when in dev mode (the security aspects associated with this API still need to be discussed). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
