bchapuis commented on code in PR #858:
URL:
https://github.com/apache/incubator-baremaps/pull/858#discussion_r1621472924
##########
baremaps-geoparquet/src/main/java/org/apache/baremaps/geoparquet/hadoop/GeoParquetGroupWriter.java:
##########
@@ -17,46 +17,13 @@
package org.apache.baremaps.geoparquet.hadoop;
-import org.apache.baremaps.geoparquet.data.GeoParquetGroupImpl;
+import org.apache.baremaps.geoparquet.common.GroupWriter;
import org.apache.parquet.io.api.RecordConsumer;
import org.apache.parquet.schema.GroupType;
-import org.apache.parquet.schema.Type;
-public class GeoParquetGroupWriter {
-
- private final RecordConsumer recordConsumer;
- private final GroupType schema;
+public class GeoParquetGroupWriter extends GroupWriter {
Review Comment:
Can we remove one of the two GeoParquetGroupWriter instead of introducing a
parent class? I probably made an error while copying the original example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
