sebr72 commented on code in PR #858:
URL:
https://github.com/apache/incubator-baremaps/pull/858#discussion_r1621477486
##########
baremaps-geoparquet/src/main/java/org/apache/baremaps/geoparquet/hadoop/GeoParquetGroupWriter.java:
##########
@@ -17,46 +17,13 @@
package org.apache.baremaps.geoparquet.hadoop;
-import org.apache.baremaps.geoparquet.data.GeoParquetGroupImpl;
+import org.apache.baremaps.geoparquet.common.GroupWriter;
import org.apache.parquet.io.api.RecordConsumer;
import org.apache.parquet.schema.GroupType;
-import org.apache.parquet.schema.Type;
-public class GeoParquetGroupWriter {
-
- private final RecordConsumer recordConsumer;
- private final GroupType schema;
+public class GeoParquetGroupWriter extends GroupWriter {
Review Comment:
I was not sure if we were going to need them with new Group support. And I
will do another PR for the refactoring. I was thinking we should remove all the
dead code at the same time once we have all the support we need for GeoParquet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
