[
https://issues.apache.org/jira/browse/BEAM-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15812568#comment-15812568
]
Stas Levin commented on BEAM-849:
---------------------------------
I see your point.
At the moment the documentation for {{getState()}} says 'Retrieves the current
state of the pipeline execution' so it seems ok to return a non-terminal state
on account of the "current" part and the asynchronous nature of the pipeline.
If, however, the intention is to return only terminal states we might want to
change this bit in the javadoc.
IMHO, it makes sense to return a non terminal state as long as it's well
communicated to the user, perhaps even by making it explicit by changing the
method's name to reflect it, e.g. {{getCurrentState()}}.
> Redesign PipelineResult API
> ---------------------------
>
> Key: BEAM-849
> URL: https://issues.apache.org/jira/browse/BEAM-849
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Pei He
>
> Current state:
> Jira https://issues.apache.org/jira/browse/BEAM-443 addresses
> waitUntilFinish() and cancel().
> However, there are additional work around PipelineResult:
> need clearly defined contract and verification across all runners
> need to revisit how to handle metrics/aggregators
> need to be able to get logs
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
